Support all codepages in path to app.config #8931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Jun 21, 2023
src/Tasks.UnitTests/AssemblyDependency/StronglyNamedDependencyAppConfig.cs
Outdated
Show resolved
Hide resolved
MichalPavlik
approved these changes
Jun 22, 2023
JaynieBai
pushed a commit
that referenced
this pull request
Jul 17, 2023
…cter (#9028) Fixes #8972 Context #8931 fixed one instance of the issue with build issues caused by localized characters in OS paths. This PR attempts to address the rest of the same unintended string -> uri conversion Changes Made Passing Stream to XmlReader.Create instead of path in order to prevent unintended string -> uri conversion Testing N/A
YuliiaKovalova
added a commit
to YuliiaKovalova/msbuild
that referenced
this pull request
Jul 18, 2023
…cter (dotnet#9028) Fixes dotnet#8972 Context dotnet#8931 fixed one instance of the issue with build issues caused by localized characters in OS paths. This PR attempts to address the rest of the same unintended string -> uri conversion Changes Made Passing Stream to XmlReader.Create instead of path in order to prevent unintended string -> uri conversion Testing N/A
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Jul 26, 2023
These overloads create a URI from the string and can cause problems with GB18030 certification, because that URI gets normalized in a way that doesn't work with all characters. We should instead pass a stream created from the file, as in dotnet#8931 and dotnet#9028. Formalize that rule for the whole repo.
YuliiaKovalova
added a commit
that referenced
this pull request
Aug 2, 2023
* Ban XmlReader overloads that take string These overloads create a URI from the string and can cause problems with GB18030 certification, because that URI gets normalized in a way that doesn't work with all characters. We should instead pass a stream created from the file, as in #8931 and #9028. Formalize that rule for the whole repo. * Add XPathDocument string ctors to banned symbols * fix 2 more cases for XmlReader.Create call * Update src/Tasks/XamlTaskFactory/RelationsParser.cs Co-authored-by: Jan Krivanek <jankrivanek@microsoft.com> * fix review comments * Update src/Tasks/XamlTaskFactory/RelationsParser.cs Co-authored-by: Rainer Sigwald <raines@microsoft.com> --------- Co-authored-by: Jan Krivanek <jankrivanek@microsoft.com> Co-authored-by: YuliiaKovalova <ykovalova@microsoft.com> Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ADO-1827728
Context
Build of FullFW app was failing for customer with specific nonenglish characters in path
Changes Made
Passing
StreamtoXmlReader.Createinstead of path - that is not grace handledTesting
Explicit test added that failed before the fix