Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify casing for boolean true in targets #9006

Merged
merged 1 commit into from Jul 11, 2023

Conversation

rainersigwald
Copy link
Member

I copy/pasted a sample usage of WriteOnlyWhenDifferent--the one with the casing True, which sparked a discussion over what MSBuild style should be. It should be lowercase.

I copy/pasted a sample usage of WriteOnlyWhenDifferent--the one with
the casing `True`, which sparked a discussion over what
MSBuild style should be. It should be lowercase.
@rainersigwald rainersigwald enabled auto-merge (squash) July 10, 2023 21:51
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rainersigwald rainersigwald merged commit 923b6fe into dotnet:main Jul 11, 2023
8 checks passed
@rainersigwald rainersigwald deleted the onetruecase branch July 11, 2023 06:46
YuliiaKovalova pushed a commit to YuliiaKovalova/msbuild that referenced this pull request Jul 18, 2023
I copy/pasted a sample usage of WriteOnlyWhenDifferent--the one with
the casing `True`, which sparked a discussion over what
MSBuild style should be. It should be lowercase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants