Removed Security.Permission reference

[maridematte]

Fixes #8962

Changes Made

Moved some refences for exception handling so System.Security.Permissions is not referenced in 8.0.
Removed System.Security.Permissions from the package list in files.

Testing

N/A

[rainersigwald]

Nice, thanks!

[JanKrivanek]

This looks good, however I believe that we'll unfortunately need to hunt and kill all the transitive dependencies as well :-/

You can use the project.assets.json files to find them and untagle the transitivity chain:

> \.build.cmd
...
> cd artifacts\obj
> findstr /spin /c:"System.Security.Permissions" project.assets.json

One example is System.Configuration.ConfigurationManager

[akoeplinger]

This would've helped with dotnet/source-build#3571 / #9158.

@maridematte do you plan on updating the PR? I can help address the PR feedback if you don't have time.

[JanKrivanek]

@akoeplinger Unfortunately the S.C.ConfigurationManager cannot be easily removed without substantial refactoring of existing code (we depend on it on core as well).
One way out is upgrading the S.S.Permissions to 8.0 as the System.Drawing dependency is no longer pulled.

Is this blocking you anywhere? The bug and PR you mentioned are both closed - so I'm trying to see what's the priority of this one

[akoeplinger]

@JanKrivanek the problem in dotnet/source-build#3571 was that a type from S.S.Permissions was loaded, this PR would've prevented that one.

As for S.C.ConfigurationManager the 8.0 version of the nuget package no longer depends on S.S.Permissions, so we'd need to upgrade to that.

This is not blocking for me, I just noticed this while looking at related PRs. But I think #8962 looks quite important if the msbuild package now can't be used on Mac/Linux.

[ericstj]

IMO this PR is goodness as it is. If consumers want, they can also reference the latest ConfigurationManager package from 8.0 to lift up the dependency that MSBuild has on it and eliminate all references to SSP. @rainersigwald let me know the SDK will do this so this should remove the file from the final layout.

[maridematte]

In an offline discussion we decided to not upgrade S.C.ConfigurationManager to the latest version, as that package should be automatically upgraded by the SDK.

[JanKrivanek]

Looks good!