Expose Binlog reader API needed for sensitive data redacting #9132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgind
reviewed
Aug 16, 2023
Forgind
approved these changes
Aug 22, 2023
MichalPavlik
approved these changes
Aug 23, 2023
donJoseLuis
approved these changes
Aug 23, 2023
JanKrivanek
force-pushed
the
proto/binlog-reading-api
branch
from
133322d
to
36add10
Compare
|
rekicking CLA bot |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #9089
Context
The simpliest way of redacting specific strings from binlogs is by replaying it via reader, while altering strings and immediately writing to new binlog via writer. To allow this scenario - the string manipulation during reading is exposed.
Based on team decision - the actual leveraging of the exposed functionality will currently live outside of this repo
Changes Made
Span<char>as an event arg - allowing in-place changes - but that would mean we'd need to create the span [which involves copying of the internal string buffer], for each read string, even those we wouldn't need to alter)