New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring back eval results #9138
Bring back eval results #9138
Conversation
@dfederm, any chance you could glance at the graph change I made here to make sure it looks legit to you? |
Looks more or less like what we brainstormed offline. Since there appears to be an e2e test gap for graph, consider running a test build with |
I manually built my test project, and I got all the properties/items/etc. I wanted regardless of graph 🙂 |
(Building it normally with and without graph also worked) |
4d7fdb3
to
6f528f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be same bug we did for TerminalLogger.
See: #9135
Still working on final testing.Tested building a simple project with and without graph and with and without specifying properties/targets/items, and it works.
Tried building a slnf (that should fail if I specify any properties/targets/items) without any of those but with and without graph, and it succeeded.
First commit just reverts the revert.
Second commit attempts to fix it.
Third commit really fixes it.
Fourth commit tweaks a test.
Fifth commit tightens the access to the graph and ensures sln/slnf graph builds aren't affected.