Revert #8726 #9188
Merged
Revert #8726 #9188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rainersigwald
commented
Aug 30, 2023
rainersigwald
commented
- Revert "Ship BuildXL assemblies in our VSIX and not our NuGet packages (Ship BuildXL assemblies in our VSIX #9185)"
- Revert "Merge pull request Add "cache add" functionality to project caching #8726 from dfederm/project-cache-vnext"
dotnet#9185)" This reverts commit 0974273.
YuliiaKovalova
approved these changes
Aug 30, 2023
donJoseLuis
approved these changes
Aug 30, 2023
rainersigwald
added a commit
that referenced
this pull request
Aug 31, 2023
)" This reverts commit 3c910ba.
rainersigwald
added a commit
that referenced
this pull request
Sep 19, 2023
* Revert "Revert 'Add "cache add" functionality to project caching' (#9188)" This reverts commit 3c910ba. * Add pkgdef entries to redirect to BXL stuff * Add missing files to binding redirects/swr * Avoid BuildXL assembly load when not opted in * Another attempt at avoiding BuildXL assembly load * Remove IBuildParameters implementation * Revert "Another attempt at avoiding BuildXL assembly load" This reverts commit 180ff51. * Make EnableDetouredNodeLauncher non-inlinable * Add Dependency(LoadHint.Sometimes) for BuildXL assemblies * [Experiment] Remove types that implement BuildXL interfaces * Revert "[Experiment] Remove types that implement BuildXL interfaces" This reverts commit 79ad288. * Remove unused EnvironmentalBuildParameters * Explicitly NGEN new dependencies * Revert "Explicitly NGEN new dependencies" This reverts commit 70b4bcf. * Fix System.Threading.Channels public key token --------- Co-authored-by: Rainer Sigwald <raines@microsoft.com> Co-authored-by: Ladi Prosek <laprosek@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.