Unset NUGET_PACKAGES in official build only #9523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
rainersigwald
force-pushed
the
make-official-build-robust-to-NUGET_PACKAGES
branch
from
82589de
to
28d5df2
Compare
The devdiv build machine images appear to have started setting the environment variable `NUGET_PACKAGES`, which caused a mismatch between the location where `drop.app` was restored (repo-local location) and where it was used from (environment-variable defined machine location), causing build failures. Co-authored-by: AR-May <67507805+AR-May@users.noreply.github.com>
rainersigwald
force-pushed
the
make-official-build-robust-to-NUGET_PACKAGES
branch
from
28d5df2
to
e27564e
Compare
|
Bypassing policy and PR builds since it's an official-build-break fix change. |
rainersigwald
deleted the
make-official-build-robust-to-NUGET_PACKAGES
branch
ladipro
pushed a commit
that referenced
this pull request
Dec 12, 2023
The devdiv build machine images appear to have started setting the environment variable `NUGET_PACKAGES`, which caused a mismatch between the location where `drop.app` was restored (repo-local location) and where it was used from (environment-variable defined machine location), causing build failures. Co-authored-by: AR-May <67507805+AR-May@users.noreply.github.com>
ladipro
pushed a commit
that referenced
this pull request
Dec 12, 2023
The devdiv build machine images appear to have started setting the environment variable `NUGET_PACKAGES`, which caused a mismatch between the location where `drop.app` was restored (repo-local location) and where it was used from (environment-variable defined machine location), causing build failures. Co-authored-by: AR-May <67507805+AR-May@users.noreply.github.com>
AR-May
added a commit
to AR-May/msbuild
that referenced
this pull request
Dec 13, 2023
This reverts commit 67d742f.
AR-May
added a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The devdiv build machine images appear to have started setting the
environment variable
NUGET_PACKAGES, which caused a mismatch betweenthe location where
drop.appwas restored (repo-local location) andwhere it was used from (environment-variable defined machine location),
causing build failures.
Co-authored-by: AR-May 67507805+AR-May@users.noreply.github.com