Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to .NET 8 GA package refs #9535

Merged
merged 6 commits into from Dec 18, 2023
Merged

Conversation

rainersigwald
Copy link
Member

Update dotnet/runtime dependencies to the 8.0 versions.

  • darc update-dependencies --id 199769
  • Add Tasks.Dataflow and Channels deps
  • Binding redirect updates to 8.0 versions

This should be the GA 8.0 build.
```
darc add-dependency --name System.Threading.Channels --repo https://dev.azure.com/dnceng/internal/_git/dotnet-runtime --version 8.0.0 --commit 5535e31a712343a63f5d7d796cd874e563e5ac14 --type product

darc add-dependency --name System.Threading.Channels --repo https://dev.azure.com/dnceng/internal/_git/dotnet-runtime --version 8.0.0 --commit 5535e31a712343a63f5d7d796cd874e563e5ac14 --type product
```
@ghost
Copy link

ghost commented Dec 13, 2023

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

@rainersigwald
Copy link
Member Author

Hey @dotnet/source-build-internal, what's the right thing to do here to fix up sourcebuild? This is for a component of 8.0.2xx that wants to reference "latest public" 8.0.0 packages (ideally without adding edges to the repo graph because we don't need to, SDK/installer construction will provide the latest for us regardless of what we reference in this repo and we can't push the .NET Framework side of our deps past whatever slightly-old version VS uses).

@mthalman
Copy link
Member

Hey @dotnet/source-build-internal, what's the right thing to do here to fix up sourcebuild? This is for a component of 8.0.2xx that wants to reference "latest public" 8.0.0 packages (ideally without adding edges to the repo graph because we don't need to, SDK/installer construction will provide the latest for us regardless of what we reference in this repo and we can't push the .NET Framework side of our deps past whatever slightly-old version VS uses).

The corresponding versions in https://github.com/dotnet/msbuild/blob/vs17.9/eng/SourceBuildPrebuiltBaseline.xml should be updated.

@rainersigwald
Copy link
Member Author

@mthalman and extend the pattern for the new ones, rather than using the suggested one that sourcebuild spit out?

@rainersigwald rainersigwald marked this pull request as ready for review December 14, 2023 22:41
@rainersigwald rainersigwald requested a review from a team as a code owner December 14, 2023 22:41
@rainersigwald rainersigwald merged commit 352c48c into vs17.9 Dec 18, 2023
8 checks passed
@rainersigwald rainersigwald deleted the exp/bump-to-net8-packages branch December 18, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants