Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the tests usage of test environment #9682

Merged

Conversation

f-alizada
Copy link
Contributor

Context

PR review of #9677 revealed some of the tests that are not using the test environment functionality which will help to reduce the code.

Changes Made

Align the usage of the tests to use the functionality of test environment.

Testing

Changed tests should pass

Copy link
Member

@surayya-MS surayya-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the PR!

src/MSBuild.UnitTests/XMake_Tests.cs Show resolved Hide resolved
@f-alizada f-alizada merged commit 0d8d09e into dotnet:main Jan 26, 2024
8 checks passed
@f-alizada f-alizada deleted the dev/f-alizada/use-test-env-in-xmake-tests branch June 14, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants