Add the missing help messages for some switches

[JaynieBai]

Fixes #9710

Context

Some of the supported command line switches are not mentioned in the help message

Changes Made

List the relevant string resource ID in s_parameterlessSwitchesMap / s_parameterizedSwitchesMap. And iterate the resource ids in the ShowHelpMessage

Testing

Before:
msbuildBefore.txt

dotnetmsbuildBefore.txt

After:
msbuildAfter.txt
netMSBuildAfter.txt

Notes

[JanKrivanek]

Looks good.

I agree that getTargetResult should probably specify that the specified target will be executed.

[JaynieBai]

Looks good.

I agree that getTargetResult should probably specify that the specified target will be executed.

Thanks, have updated the help message for this property.

[ladipro]

Thank you, I've left a few comments inline. For testing, can you please compare the help output before and after, and from both MSBuild.exe and dotnet build?

[JaynieBai]

Thank you, I've left a few comments inline. For testing, can you please compare the help output before and after, and from both MSBuild.exe and dotnet build?

I upload the text based on test. There is a change in the order of the switches. Please have a look if that is acceptable. -help is earlier than other no parameters switches since the

msbuild/src/MSBuild/CommandLineSwitches.cs

Lines 204 to 227 in 563c7b0

	{
	//---------------------------------------------------------------------------------------------------------------------------------------------------
	// Switch Names Switch Id Dup Error Light up key
	//---------------------------------------------------------------------------------------------------------------------------------------------------
	new ParameterlessSwitchInfo( new string[] { "help", "h", "?" }, ParameterlessSwitch.Help, null),
	new ParameterlessSwitchInfo( new string[] { "version", "ver" }, ParameterlessSwitch.Version, null),
	new ParameterlessSwitchInfo( new string[] { "nologo" }, ParameterlessSwitch.NoLogo, null),
	new ParameterlessSwitchInfo( new string[] { "noautoresponse", "noautorsp" }, ParameterlessSwitch.NoAutoResponse, null),
	new ParameterlessSwitchInfo( new string[] { "noconsolelogger", "noconlog" }, ParameterlessSwitch.NoConsoleLogger, null),
	new ParameterlessSwitchInfo( new string[] { "filelogger", "fl" }, ParameterlessSwitch.FileLogger, null),
	new ParameterlessSwitchInfo( new string[] { "filelogger1", "fl1" }, ParameterlessSwitch.FileLogger1, null),
	new ParameterlessSwitchInfo( new string[] { "filelogger2", "fl2" }, ParameterlessSwitch.FileLogger2, null),
	new ParameterlessSwitchInfo( new string[] { "filelogger3", "fl3" }, ParameterlessSwitch.FileLogger3, null),
	new ParameterlessSwitchInfo( new string[] { "filelogger4", "fl4" }, ParameterlessSwitch.FileLogger4, null),
	new ParameterlessSwitchInfo( new string[] { "filelogger5", "fl5" }, ParameterlessSwitch.FileLogger5, null),
	new ParameterlessSwitchInfo( new string[] { "filelogger6", "fl6" }, ParameterlessSwitch.FileLogger6, null),
	new ParameterlessSwitchInfo( new string[] { "filelogger7", "fl7" }, ParameterlessSwitch.FileLogger7, null),
	new ParameterlessSwitchInfo( new string[] { "filelogger8", "fl8" }, ParameterlessSwitch.FileLogger8, null),
	new ParameterlessSwitchInfo( new string[] { "filelogger9", "fl9" }, ParameterlessSwitch.FileLogger9, null),
	new ParameterlessSwitchInfo( new string[] { "distributedfilelogger", "dfl" }, ParameterlessSwitch.DistributedFileLogger, null),
	#if DEBUG
	new ParameterlessSwitchInfo( new string[] { "waitfordebugger", "wfd" }, ParameterlessSwitch.WaitForDebugger, null),
	#endif
	};

[ladipro]

I upload the text based on test. There is a change in the order of the switches. Please have a look if that is acceptable.

I can't imagine something would depend on the order. Reviewers, please chime in. I've left a few inline comments. Thank you!

[JaynieBai]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[JaynieBai]

There are conflicts since the new analyzer switch in the commit f744eb5#diff-c0f68f9abf837e0ecb1e4de52b83e9e81d6934c5596bc213e4b1de45e591d7ce But there is no help message for this analyzer switch. @JanKrivanek , Could you give more info about this switch? Should we show the help message for this switch?

[JanKrivanek]

There are conflicts since the new analyzer switch in the commit f744eb5#diff-c0f68f9abf837e0ecb1e4de52b83e9e81d6934c5596bc213e4b1de45e591d7ce But there is no help message for this analyzer switch. @JanKrivanek , Could you give more info about this switch? Should we show the help message for this switch?

Disccussed offline.
-analyze should not be included in help message now

[JanKrivanek]

This seems not complete. This is what we support based on code:

msbuild/src/MSBuild/TerminalLogger/TerminalLogger.cs

Lines 309 to 318 in 9ead13b

	switch (parameterName.ToUpperInvariant())
	{
	case "V":
	case "VERBOSITY":
	ApplyVerbosityParameter(parameterValue);
	break;
	case "SHOWCOMMANDLINE":
	TryApplyShowCommandLineParameter(parameterValue);
	break;
	}

in addition to

msbuild/src/MSBuild/XMake.cs

Lines 2826 to 2827 in 9ead13b

	// Find default configuration so it is part of telemetry even when default is not used.
	// Default can be stored in /tlp:default=true|false|on|off|auto

So basicaly the parameters is a semicolon separated list - par1;par2;par3..., where each parameter is either in a form of setting=value or just setting

The settings currently can be:

• default - requires value
• v|verbosity - requires value
• ShowCommandline - just setting, value must not be specified

Please ping me once you have formulation of this section that incorporates the above and I'll have a look and signoff or object :)