Remove result indicator from test summary #9929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nohwnd can you merge conflicts? |
|
@baronfel done (not a super developer, I just did not push). |
baronfel
reviewed
Mar 27, 2024
|
@AR-May merged conflicts, please review. |
|
@MichalPavlik all green, please approve and merge or let me know what to change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/sdk#39665
Context
Reporting the result in the test summary creates inconsistencies. When the build finished with warnings the tests would still report "succeded", unless we duplicate a lot of logic.
Changes Made
Removed the explicit result, and instead I just colorize the most important test result count, so failed tests are highlighted when there are any.
Moved the test summary above the final build result.
original:
new (after merge with newest main):
Testing
Notes