Analyzers acquisition experience #9977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
force-pushed
the
dev/ykovalova/analyzers_aquisition_experience
branch
from
3b41327
to
53a7c8b
Compare
JanKrivanek
reviewed
Apr 10, 2024
src/Build/BuildCheck/Acquisition/BuildCheckAcquisitionModule.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Acquisition/BuildCheckAcquisitionModule.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Infrastructure/BuildCheckConnectorLogger.cs
Outdated
Show resolved
Hide resolved
JanKrivanek
requested changes
Apr 12, 2024
src/Build/BuildCheck/Acquisition/BuildCheckAcquisitionModule.cs
Outdated
Show resolved
Hide resolved
src/Build/BuildCheck/Acquisition/BuildCheckAcquisitionModule.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR implements acquisition flow for custom analyzers.
The process can be described the next way:
A Custom Analyzer library contains a file
Company.AnalyzerTemplate.props.If this analyzer is referenced from any solution, MSBuild invokes intrinsic function
RegisterAnalyzerduring the evaluation. It emitsBuildCheckAcquisitionEventArgsif the parsed path to custom analyzer is valid.This event is handled by
BuildCheckConnectorLogger: it passes the info toIBuildCheckManager.ProcessAnalyzerAcquisition.Tests
Manual and unit tests.
I plan to cover e2e scenarios once MSBuild.Build package with BuildCheck infrastructure is available for public reference (it is needed for custom templates).