Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Remove crypto functions from statically linked OpenSSL #31

Merged
merged 2 commits into from
Aug 13, 2021

Conversation

ManickaP
Copy link
Member

Contributes to dotnet/runtime#55639

@ManickaP
Copy link
Member Author

Depends on dotnet/dotnet-buildtools-prereqs-docker#494

We'll probably need to update image reference afterwards here:

image: ubuntu-18.04-msquic-20210628192849-7f197aa

@ManickaP ManickaP requested review from safern and wfurt August 13, 2021 15:39
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green.

@wfurt
Copy link
Member

wfurt commented Aug 13, 2021

Linux build finished. Do we know if runtime tests pass @ManickaP ?

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt wfurt merged commit 73d128a into main Aug 13, 2021
@wfurt wfurt deleted the mapichov/openssl_sans_crypto branch August 13, 2021 18:46
@ManickaP
Copy link
Member Author

@wfurt I ran with it locally and haven't seen any issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants