Invoke interceptor broken for generic grains

[dancvogel]

Just upgraded to 1.3.0 and am having issue with generic grains.

An example interface and class that's showing this issue:

public interface IGenericTest<T> : IGrainWithIntegerKey
{
    Task<T> PrintType(T obj);
}

public class GenericTestGrain<T> : Grain, IGenericTest<T>
{
    public Task<T> Print(T obj)
    {
        Debug.WriteLine("TEST");
        return Task.FromResult(obj);
    }
}

Also have invoke interceptor setup up, for simplicity looks like this:

providerRuntime.SetInvokeInterceptor((method, request, grain, invoker) =>
{
    return invoker.Invoke(grain, request);
});

then using the grain like:

var grain = await GrainFactory.GetGrain<IGenericTest<int>>(0); // Runs without error.
await grain.Print(1);

Getting the grain seems to be fine, but when I call the method on the grain I get:

System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.

at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
at Orleans.InterceptedMethodInvokerCache.GetInterfaceToImplementationMap(Int32 interfaceId, Type implementationType)
at Orleans.InterceptedMethodInvokerCache.CreateInterceptedMethodInvoker(Type implementationType, Int32 interfaceId, IGrainMethodInvoker invoker)
at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
at Orleans.InterceptedMethodInvokerCache.GetOrCreate(Type implementationType, Int32 interfaceId, IGrainMethodInvoker invoker)
at Orleans.Runtime.InsideRuntimeClient.InvokeWithInterceptors(IAddressable target, InvokeMethodRequest request, IGrainMethodInvoker invoker)
at Orleans.Runtime.InsideRuntimeClient.<Invoke>d__57.MoveNext()

When I remove the SetInvokeInterceptor call everything is happy. Seems like the code is trying to use the typed interface name as the key instead of the generic.

[sergeybykov]

To clarify, the exact same code works in 1.2.3/1.2.4?

[dancvogel]

I wasn't using the SetInvokeInterceptor before. I just updated from 1.1.3 to 1.3.0. so didn't have it as an option. Was using a custom wrapping before.

[sergeybykov]

Then sounds like a bug (unsupported case) with interceptors.

[sergeybykov]

If there's a quick fix, we could include it in 1.3.1 that we are in the process of assembling.

[ajorkowski]

In the InterceptedMethodInvokerCache.GetInterfaceToImplementationMap method, the line that is failing is:

GrainInterfaceUtils.GetMethods(interfaceTypes[interfaceId])

The problem is that the interfaceId is from the message, which I think is the compile-time id, whereas the dictionary is being built by the runtime interface (I think). Maybe it should fallback to the passed in type?

var interfaceType = interfaceTypes.ContainsKey(interfaceId) ? interfaceTypes[interfaceId] : implementationType;

GrainInterfaceUtils.GetMethods(interfaceType)

Although that doesn't seem entirely correct, since that would be grabbing the methods from a non-interface?

[gabikliot]

There was a similar question, generic grains without interceptors, on Stack overflow.

[dancvogel]

@gabikliot It is probably mine. I asked there before I discovered the interceptor thing and decided it was a bug (unsupported case) in Orleans.

[ReubenBond]

Hi @dancvogel, the issue has been fixed in master and will be included in the next release