ClientConfiguration vs OrleansConfiguration assymetry

[yevhen]

While I can perfectly load OrleansConfiguration using

new OrleansConfiguration().Load(new StringReader(embeddedResourceFile));

The ClientConfiguration does not provide this method in it's public interface, so currently I'm using this filthy hack:

var loader = result.GetType().GetMethod("Load", BindingFlags.Instance | BindingFlags.NonPublic, null, new[] {typeof(TextReader)}, null);
loader.Invoke(result, new object[]{LoadFromEmbeddedResource(assembly, fullResourcePath)});

Also, I think renaming OrleansConfiguration to 'ServerConfiguration` will add consistency and perfect symmetry (Client/Server). The principle of "no surprises" - is a hallmark of a good API =))

[gabikliot]

There is no more OrleansConfiguration. We renamed the class to ClusterConfiguration. The file is still called OrleansConfiguration.cs and we should change that.

Yes in favor of adding ClientConfiguration.Load(new StringReader(embeddedResourceFile));

[yevhen]

Great!

[jthelin]

I renamed the files to avoid confusion. PR #45

Adding symmetrical ClientConfiguration.Load method should be done as separate PR.

[jthelin]

I created PR #47 to change ClientConfiguration.Load method public.

@gabikliot - could you take a look at this PR because it seems like the AdjustConfiguration function got disconnected somewhere along the way, but isn't it needed for some streaming providers?

[gabikliot]

I will.

[gabikliot]

Merged #47.