Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release for BinaryFormatter Removal? #7028

Closed
bcuff opened this issue Mar 17, 2021 · 3 comments
Closed

Release for BinaryFormatter Removal? #7028

bcuff opened this issue Mar 17, 2021 · 3 comments
Assignees
@ReubenBond
Labels
stale Issues with no activity for the past 6 months
Milestone
3.5.0

Comments

@bcuff
Copy link

bcuff commented Mar 17, 2021

I'm currently using the latest release, 3.4.1. I'm running on dotnet 5 so I'm still running into errors related to BinaryFormatter not being supported in dotnet 5 when exceptions are thrown. I noticed that #6922 removes BinaryFormatter but this change isn't in the 3.4.1 release.

Will there be a release that includes this change in the near future?

Thanks.
@ReubenBond
Copy link
Member

Hi Brandon, it would be a breaking change to release that in 3.x, but there are workarounds:
#6805 (comment)

Ultimately, maybe we will need to make that breaking change, since the workaround is a hassle. cc @bradygaster

@ReubenBond ReubenBond self-assigned this Mar 17, 2021
@bcuff
Copy link
Author

bcuff commented Mar 18, 2021 •
edited
Loading

Yeah, I saw the workaround but I was reluctant to do that because my application is an internet facing web application.

@ReubenBond ReubenBond added this to the 3.5.0 milestone Apr 6, 2021
@ReubenBond ReubenBond mentioned this issue Aug 13, 2021
Merged
@ReubenBond
Copy link
Member

Fixed by #7198

@ghost ghost locked as resolved and limited conversation to collaborators Sep 25, 2021
@ghost ghost added the stale Issues with no activity for the past 6 months label Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ReubenBond ReubenBond

Labels
stale Issues with no activity for the past 6 months
Projects
None yet
Milestone
3.5.0
Development

No branches or pull requests
2 participants
@ReubenBond @bcuff