-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to ILBasedSerializer when BinaryFormatter is disabled #7198
Fallback to ILBasedSerializer when BinaryFormatter is disabled #7198
Conversation
454dea3
to
d428a35
Compare
d428a35
to
aedbc6e
Compare
@ReubenBond which formatter should we prefer? The unsafe one? |
I would stick with what works for now. They are only used as a fallback, eg for exceptions. |
What is the long term plan here? I thought ILBasedSerializer has been marked as obsolete and a new serializer has been developed a while ago but is not stable? And how do these serializers with exceptions that have custom properties? |
@SebastianStehle yes, it was a roller coaster: The long term plan is already in-place in main:
We will likely need some options for developers who are serializing grain state using the current serialization framework, at some point. 4.x is not wire-compatible with 3.x, so rolling upgrades are not supported between those major versions. |
Thanks a lot of your good explanation. |
…t#7198) * Fallback to ILBasedSerializer when BinaryFormatter appears to be disabled at runtime * Multi-target tests to .NET 5.0 and fix subsequent errors and warnings
* Fallback to ILBasedSerializer when BinaryFormatter appears to be disabled at runtime * Multi-target tests to .NET 5.0 and fix subsequent errors and warnings
Fix for #7028 & #6805.
Developers can enable BinaryFormatter on .NET 5.0+ using the workaround here: #6805 (comment)
Otherwise, ILBasedSerializer will be used as the fallback on .NET 5.0+