Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Json Converter does not work in Orleans #8252

Closed
andtii opened this issue Jan 5, 2023 · 4 comments · Fixed by #8300
Closed

Custom Json Converter does not work in Orleans #8252

andtii opened this issue Jan 5, 2023 · 4 comments · Fixed by #8300

Comments

@andtii
Copy link

andtii commented Jan 5, 2023

Using a custom json converter for System.Text.Json is throwing an exception. It works when serializing directly using JsonSerializer but not when passed to the grain method.

image

The exception stacktrace is
image

Here is a repro
https://github.com/andtii/OrleansCustomJsonConverter

@ghost ghost added the Needs: triage 🔍 label Jan 5, 2023
@TheFo2sh
Copy link

any updates ?

@ReubenBond ReubenBond self-assigned this Jan 31, 2023
@ReubenBond ReubenBond added this to the 7.1.0 milestone Jan 31, 2023
@ReubenBond
Copy link
Member

Thank you for reporting and for providing a repro. I have a fix which I hope to have ready and merged soon. Apologies for the hassle.

image

@andtii
Copy link
Author

andtii commented Jan 31, 2023

Sweeet!

@ReubenBond
Copy link
Member

ReubenBond commented Jan 31, 2023

Fix PR: #8300. I incorporated your repro code into the tests, @andtii - thank you

@ghost ghost added the Status: Fixed label Feb 1, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants