Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PooledArrayBufferWriter.AsMemory #8300

Merged
merged 4 commits into from Feb 1, 2023
Merged

Fix PooledArrayBufferWriter.AsMemory #8300

merged 4 commits into from Feb 1, 2023

Conversation

ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Jan 31, 2023 •
edited

  • PooledArrayBufferWriter.AsMemory was broken, breaking JSON serialization
  • Added more test coverage (thank you to @andtii for the repro code)
  • Fixed an F# serialization bug discovered after adding test coverage

Fixes #8252

Microsoft Reviewers: Open in CodeFlow

@ReubenBond ReubenBond mentioned this pull request Jan 31, 2023
Closed
@ReubenBond ReubenBond added this to the 7.1.0 milestone Jan 31, 2023
@ReubenBond ReubenBond merged commit 58b072e into dotnet:main Feb 1, 2023
@ReubenBond ReubenBond deleted the fix/pooledarraybufferwriter-asmemory branch February 1, 2023 01:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@benjaminpetit benjaminpetit

Labels
None yet
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

Custom Json Converter does not work in Orleans
2 participants
@ReubenBond @benjaminpetit