Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orleans 7 - PersistentStateAttribute - StateName really should be set #8708

Closed
zeus82 opened this issue Nov 5, 2023 · 1 comment · Fixed by #8718
Closed

Orleans 7 - PersistentStateAttribute - StateName really should be set #8708

zeus82 opened this issue Nov 5, 2023 · 1 comment · Fixed by #8718

Comments

@zeus82
Copy link
Contributor

zeus82 commented Nov 5, 2023

I'm in the process of migrating from Orleans 3 to 7. With Orleans 3.x, Basically all my grains had something like this:

[PersistentState(null)] IPersistentState<State> data

Where the 'State' class was an inner class of my grain. This worked fine, but now with Orleans 7, these all somehow get data set as the GrainTypeString and so it seems like the ADO persistence provider gets confused because I see its trying to deserialise the wrong type. I was able to fix it by adding nameof(MyGrain) instead of null.

It would be great if now the PersistentStateAttribute prevented you from setting stateName to null!

@ghost ghost added the Needs: triage 🔍 label Nov 5, 2023
@ReubenBond
Copy link
Member

@zeus82 good idea

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants