Serialization: Stack<T> is deserialized in reversed order

[DmitryZhelnin]

Consider following example:

public class MyGrain : IMyGrain
{
    public Task<Stack<int>> GetStack()
    {
        var stack = new Stack<int>();
        stack.Push(1);
        stack.Push(2);
        stack.Push(3);
        stack.Push(4);
        return Task.FromResult(stack);
    }
}

And the calling code:

var stack = await myGrain.GetStack();
var value = stack.Pop(); // returns 1

Here in StackCodec during deserealization process values from original stack are just pushed to the new stack what makes the order to be reversed.

orleans/src/Orleans.Serialization/Codecs/StackCodec.cs

Line 97 in cd09126

result.Push(_fieldCodec.ReadValue(ref reader, header));

[ReubenBond]

Thank you for reporting. I've opened #8768 with a fix + test.

[ReubenBond]

I've opened #8769 to ensure that this does not happen again.