Make Namespace access modifier public in ImplicitStreamSubscriptionAttribute. Add Provider property. #1270
Conversation
|
LGTM from my side. |
gabikliot
changed the title
| internal string Namespace { get; private set; } | ||
| public string Namespace { get; private set; } | ||
|
|
||
| public string Provider { get; private set; } |
There was a problem hiding this comment.
If stream provider is specified, implicit subscription pub sub system must respect it and only create subscription to this grain for streams from the specified stream provider. I don't see that change here..
Options:
- Don't allow specification of stream provider name.
- Update Implicit subscription pubsub system to respect specified stream provider name.
centur
force-pushed
the
implicit-stream-subscription-attr-issue1266
branch
from
095360a
to
fd3a961
Compare
|
@centur , my suggestion to you will be to split this PR into 2:
It will be probably much easier to get the 1st one approved by @jason-bragg , while you negotiate the 2nd one. ;-) |
|
Ok. I've synchronized my branch with latest so I'll do 2 separate PRs then, I feel that second part - putting restriction on the stream provider by name will require extra unit tests :) |
…rovider Provider property and create constructor which takes it as a second parameter.
centur
force-pushed
the
implicit-stream-subscription-attr-issue1266
branch
from
fd3a961
to
eb1f4a2
Compare
…pace field public
|
ok the smallest pull request I've ever seen :) |
…r-issue1266 Make Namespace access modifier public in ImplicitStreamSubscriptionAttribute. Add Provider property.
|
Thank you, @centur! Though I don't think one can beat https://github.com/dotnet/orleans/pull/955/files as the tiniest PR. :-) |
|
That one is definitely the shortest one, which also fixes issue |
Issue #1266 : update Namespace access modifier to public. Add Provider property and create constructor which takes it as a second parameter.