Check declaring types when performing accessibility checks for code gen. #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeybykov
added a commit
that referenced
this pull request
Jan 16, 2016
Check declaring types when performing accessibility checks for code gen.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1283.
I haven't run tests on this, it's just a quick fix, so we'll see what CI says.
The change is this:
IsTypeIsInaccessibleForSerializationnow has only one path which can returnfalse(signifying that a type is accessible for serialization). Each check can trigger short-circuiting & returntrueif a type is inaccessible, but otherwise execution will fall through to the next check.Hopefully the code is easier to reason about now that there is only one happy path.
We also check the accessibility of the declaring type to fix #1283.