Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize SerializationManager before CodeGeneratorManager #1345

Merged
merged 1 commit into from Jan 28, 2016
Merged

Initialize SerializationManager before CodeGeneratorManager #1345

merged 1 commit into from Jan 28, 2016

Conversation

cata
Copy link
Contributor

@cata cata commented Jan 28, 2016

fixes #1344

@ReubenBond
Copy link
Member

Thanks, @ca-ta! Looks good to me. The AssemblyProcessor will register generated serializers when they are loaded (post-generation). Initialization order does not affect it, so I believe this is a sound change.

@ReubenBond ReubenBond self-assigned this Jan 28, 2016
ReubenBond added a commit that referenced this pull request Jan 28, 2016
@ReubenBond
Merge pull request #1345 from ca-ta/master
0942cb6 
Initialize SerializationManager before CodeGeneratorManager
@ReubenBond ReubenBond merged commit 0942cb6 into dotnet:master Jan 28, 2016
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ReubenBond ReubenBond

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Silo crashes at start-up attempting to generate serializers
4 participants
@cata @ReubenBond @sergeybykov @dnfclas