Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary table scan when finding reminder entries to delete #1348

Merged
merged 1 commit into from Jan 29, 2016

Conversation

jdom
Copy link
Member

@jdom jdom commented Jan 29, 2016

There's a possibility to filter by partition key instead with the same results. This was timing out when the reminders table becomes too large.

There's a possibility to filter by partition key instead with the same results. This was timing out when the reminders table becomes too large.
@gabikliot
Copy link
Contributor

Looks good, good catch, but we don't realy use that method. Its only uses to DeleteTableEntries, which is only used in Test. But I know understand why Test cleanup would sometimes fail for reminder tests. I suspected it has something to do with the way we inefficiently delete this table. Now its clear.

gabikliot pushed a commit that referenced this pull request Jan 29, 2016
Avoid unnecessary table scan when finding reminder entries to delete
@gabikliot gabikliot merged commit 10a54a7 into dotnet:master Jan 29, 2016
@jdom jdom deleted the functional-tests-fixes branch January 29, 2016 22:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants