CodeGen: Add support for F# interfaces #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2016
|
@jthelin: This is a regression from 1.0.9 - I think it qualifies as a bug. |
| @@ -0,0 +1,54 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Do we need to add another project? Can't this be added to TestGrainInterfaces.csproj instead?
There was a problem hiding this comment.
We need another project to test that one can indeed derive from a C# interface in an external assembly.
|
LGTM. Just a few minor queries from @sergeybykov then should be able to merge i think @ca-ta |
sergeybykov
added a commit
that referenced
this pull request
Feb 5, 2016
CodeGen: Add support for F# interfaces
|
Thank you, @ca-ta! |
|
@sergeybykov, @jthelin - Thank you for the CR, and thanks for merging! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1349, includes corresponding tests.
Background
F# interface definitions do not require parameter names. It is idiomatic to omit parameter names for trivial interface methods:
However, Orleans code generation requires parameter names to be present. The PR addresses this by generating such names when not present, by suffixing the string
"arg"with the parameter's index (arg0,arg1, etc.).