Fixed Azure table property being not sanitized. #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dVakulen
changed the title
| key = key.Replace('/', '_'). // Forward slash | ||
| Replace('\\', '_'). // Backslash | ||
| Replace('#', '_'). // Pound sign | ||
| Replace('?', '_'); // Question mark |
There was a problem hiding this comment.
I know I'm nit picking, but could you put the dots before the method invocation, such as .Replace(
There was a problem hiding this comment.
BTW, feel free to push back on the comment if it's going to require a lot of context switching or fighting git from you, this is a VERY minor comment that I don't feel absolutely must be addressed 👅
There was a problem hiding this comment.
Already fought and won.
|
Thanks for the PR. The code looks good... now :) |
dVakulen
force-pushed
the
azure-table-prop-sanitizing
branch
from
2eb8e19
to
2e2b5ca
Compare
jdom
added a commit
that referenced
this pull request
Feb 5, 2016
Fixed Azure table property being not sanitized.
|
Thanks @dVakulen for the quick turnaround :) |
|
👍 |
|
Great catch by @centur ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return values of pure method
string.Replaceweren't used.Fixes #1385.