Add helper methods to AzureClient and AzureSilo for easier programmatic config #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -123,12 +140,12 @@ private static void InitializeImpl_FromFile(FileInfo configFile) | |||
| InitializeImpl_FromConfig(config); | |||
| } | |||
|
|
|||
| private static string GetDeploymentId() | |||
| internal static string GetDeploymentId() | |||
| { | |||
| return GrainClient.TestOnlyNoConnect ? "FakeDeploymentId" : serviceRuntimeWrapper.DeploymentId; | |||
There was a problem hiding this comment.
Out of curiosity, would there be a need to use "FakeDeploymentId" elsewhere? E.g. in some comparison operation?
There was a problem hiding this comment.
I don't know. I don't even see it being used in tests. Probably a leftover from the past. But this PR isn't concerned with it.
|
@dotnet-bot test this please |
…eConfiguration() helper methods.
sergeybykov
force-pushed
the
azure-config
branch
from
c265ca4
to
506dc2b
Compare
|
I renamed "DefaultConfig" to "DefaultConfiguration". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AzureClient.DefaultAzureConfig() and AzureSilo.DefaultAzureConfig() helper methods.
Usage examples are in https://github.com/sergeybykov/orleans/blob/sample/Samples/AzureWebSample/WebRole/Default.aspx.cs#L16 and https://github.com/sergeybykov/orleans/blob/sample/Samples/AzureWebSample/OrleansAzureSilos/WorkerRole.cs#L49.