MemoryStorage bug fix when calling Clear state #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly writing to it. Previous to 1.2.1 this was actually throwing a cryptic NullReferenceException instead, but commit a1d3595 partially addressed it (but not the etag mismatch).
|
LGTM. |
|
Don't we need a 1.2.2 release with this fix, considering that people use it in production? |
|
I don't think so. It's only memory storage, shouldn't be used in production. Plus, the bug was only in clear state method, also rarely used. |
|
Actually @gabikliot, I think we do plan to release this. The reason I submitted this PR is because this started happening more often since the PubSubRendevouzGrain now calls clear state more often. And some people are using MemoryStorage in prod for pub sub (who contacted us with the issue). Having said that, I think I would wait until there's a fix for #1739, and then publish 1.2.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemoryStorage had eTag mismatch when clearing the state and subsequently writing to it.
Previous to 1.2.1 this was actually throwing a cryptic NullReferenceException instead, but commit a1d3595 partially addressed it (but not the etag mismatch).