Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterConfiguration extension for setting Startup class #1842

Merged
merged 2 commits into from
Jun 17, 2016

Conversation

jasonholloway
Copy link
Contributor

Just what you'd expect from the title, I'd suppose.

I was moaning a little bit on #1765 about configuring the startup class being non-obvious, especially in the context of TestCluster, which prepopulates overrides.

So - a small helper extension method to set the StartupTypeName property on all nodes.

/// Configures all cluster nodes to use the specified startup class for dependency injection.
/// </summary>
/// <typeparam name="TStartup">Startup type</typeparam>
public static void UseStartupClass<TStartup>(this ClusterConfiguration config)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rename it to UseStartupType, to be consistent with the actual configuration setting.

@jdom
Copy link
Member

jdom commented Jun 15, 2016

Great, thanks for this, it will also make it easier to do #1765 without breaking many users if they are using programmatic config.

@jdom jdom self-assigned this Jun 15, 2016
@jasonholloway
Copy link
Contributor Author

Just out of interest, @jdom, would I have been better to rebase and force push here?

@jdom
Copy link
Member

jdom commented Jun 17, 2016

Since the changeset is simple, a squash and rebase is typically better if you know how to do it. But it is still fine, since now GitHub has a way to accept the PR by doing a squash and rebase instead of a normal merge.
For huge PRs though, you don't want to squash and rebase constantly while people are reviewing because it's hard to see what changed from version to version, and we only ask people to rebase once it's ready to be merged.

@jdom jdom merged commit f37d0a4 into dotnet:master Jun 17, 2016
@jdom
Copy link
Member

jdom commented Jun 17, 2016

Thanks @jasonholloway !

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants