Fixed null MethodInfo in Interceptors #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen method is not declared directly on the grain interface. Commit by Allon Guralnek <allon.gu@gigya-inc.com> On branch: refs/heads/Interceptors_FixNullMethodInfo
|
Hi @Allon-Guralnek, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@Allon-Guralnek, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
Thanks for the PR! Looks good to me, I'm glad to see that this feature is getting used already. I'll leave this open for a while longer so others can take a look. |
|
LGTM |
ticup
added a commit
to ticup/orleans
that referenced
this pull request
Aug 12, 2016
…t case. Incorporate bug fix: dotnet#1938
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When intercepting a grain method that's not defined directly on the grain interface, but rather on an interface that the grain interface "inherits" from (e.g.
interface IMyGrain : IOtherInterface, IGrainWithIntegerKey { }), theMethodInfothat is supplied to the intercepting method isnull.This pull request changes the way methods are discovered via reflection to include all interfaces that are "inherited" (for lack of a better word) by the grain interface.
It also adds this test case to prevent regression.