Persistent stream pulling agent now uses exponential backoff #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ountering errors when reading from queues.
| { | ||
| var now = DateTime.UtcNow; | ||
| // Try to cleanup the pubsub cache at the cadence of 10 times in the configurable StreamInactivityPeriod. | ||
| if ((now - lastTimeCleanedPubSubCache) >= config.StreamInactivityPeriod.Divide(StreamInactivityCheckFrequency)) |
There was a problem hiding this comment.
the cache cleanup code logically does not belong inside the func, but rather outside the loop, or even better in a separate timer. you can improve it later on.
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persistent stream pulling agent now uses exponential backoff when encountering errors when reading from queues.
This prevents agents from spamming backend queue services that are encountering transient errors.
If no data is read, usual retry timer is applied. Exponential backoff is only triggered when errors occur.