CodeGen: fix generated DeepCopy method to call RecordObject earlier #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,7 +62,7 @@ public override bool Equals(object x, object y) | |||
|
|
|||
| public override int GetHashCode(object obj) | |||
| { | |||
| return obj == null ? 0 : obj.GetHashCode(); | |||
| return obj == null ? 0 : RuntimeHelpers.GetHashCode(obj); | |||
There was a problem hiding this comment.
Not strictly required for this change, but a potential bug. Just as we use object.ReferenceEquals above this, we should call RuntimeHelpers.GetHashCode rather than obj.GetHashCode so that we are not dependent on user-defined implementations of GetHashCode. It's not likely to cause an issue, but it's possible.
ReubenBond
force-pushed
the
fix-codegen-deepcopy-recordobject
branch
from
92628e6
to
0271081
Compare
| @@ -21,6 +21,8 @@ | |||
|
|
|||
| namespace UnitTests.Serialization | |||
| { | |||
| using TestGrainInterfaces; | |||
|
|
|||
| /// <summary> | |||
There was a problem hiding this comment.
Instead of redefining CircularTest1, we use the implementation in TestGrainInterfaces because that implementation has a generated serializer whereas this assembly does not, due to [assembly: SkipCodeGeneration] attribute.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently generated
DeepCopymethod incorrectly callsRecordObjectafter copying fields instead of before. This results in circular references involving being incorrectly serialized, resulting in a loss of referential equality.The fix is to simply emit the call to
RecordObjectbefore the field-copying calls.This was not failing in our test suite (
Serialize_CircularReference) because the assembly holding the recursively defined type has the[SkipCodeGeneration]attribute, so a serializer was not being generated and so the fallback serializer was being used.