Fix support for serializing SByte[] #2140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have optimizations for serializing certain types, including various array types.
Serialization is broken for
SByte[]
because it is serialized without optimization, but erroneously deserialized with an optimization forbyte[]
. Since the optimized serialization occupies half the space, this results in incorrect deserialization.This PR fixes that and expands test coverage to include this case.