Fix invocation interception for grain extensions #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
fix-extension-interception
branch
from
be1a18f
to
bf88822
Compare
|
@dotnet-bot test this please |
|
Tested, working |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke the
PreInvocationCallbackWithStreamTesttest with #2502.The test checks that
IGrainExtensions can have their methods intercepted by grains. Previously we were passing anullMethodInfoparameter to the interceptor, since the correct implementation method could not be found.#2502 broke that by throwing an exception in the event that an implementation method cannot be found.
This PR fixes it again by mapping the interface method to the extension method in the event that the incoming request is destined for the extension object.
As you can see, it's a very simple fix. Functionals are running.