Fixed #2643 Added a data adapter to azure queue stream provider by @jason-bragg #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data adapter allows users to use the new v2 versions of sequence token and batch container without risking changes to the original versions, which are being used in production services. The adapter also allows service developers to control how data is structured in azure queues, enabling the streaming of azure queue events of legacy systems or systems integrated with other non-orleans services.
| @@ -4,8 +4,16 @@ namespace Orleans.Providers.Streams.AzureQueue | |||
| { | |||
| /// <summary> | |||
| /// Persistent stream provider that uses azure queue for persistence | |||
| /// WARNING: This version is maintained for compatability purposes. New services should use AzureQueueStreamProviderV2 as it supports external serializers. | |||
There was a problem hiding this comment.
WARNING: This version is maintained for compatability purposes. New services should use AzureQueueStreamProviderV2 as it supports external serializers [](start = 8, length = 151)
Should we mark this class as obsolete?
|
@sergeybykov the exception in tests: Ought to go away if build-time code generation is enabled for the Azure utils project |
ReubenBond
reviewed
Jan 30, 2017
| @@ -114,25 +114,11 @@ | |||
| <None Include="project.json" /> | |||
| </ItemGroup> | |||
| <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" /> | |||
| <!-- Begin Orleans: Without these lines the project won't build properly --> | |||
There was a problem hiding this comment.
This change should be un-reverted so that the code generator can operate at build-time. The runtime code generator cannot access those internal types.
There was a problem hiding this comment.
I just pushed with that commit removed. :-)
sergeybykov
force-pushed
the
2643-AQ-v2
branch
from
f28c950
to
8b3b273
Compare
ReubenBond
reviewed
Jan 30, 2017
| @@ -114,25 +114,11 @@ | |||
| <None Include="project.json" /> | |||
| </ItemGroup> | |||
| <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" /> | |||
| <!-- Begin Orleans: Without these lines the project won't build properly --> | |||
| <PropertyGroup> | |||
| <OrleansProjectType>Server</OrleansProjectType> | |||
There was a problem hiding this comment.
these particular lines aren't needed, though - we don't use this property anymore
sergeybykov
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #2643, which has a build failure in vNext.