Fix typos in format strings #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdom
reviewed
Mar 16, 2017
| @@ -279,7 +279,7 @@ protected class UpdateNotificationMessage : INotificationMessage | |||
| /// <inheritdoc/> | |||
| public override string ToString() | |||
| { | |||
| return string.Format("v{0} ({1} updates by {2}) etag={2}", Version, Updates.Count, Origin, ETag); | |||
| return string.Format("v{0} ({1} updates by {2}) etag={3}", Version, Updates.Count, Origin, ETag); | |||
There was a problem hiding this comment.
I'm OK checking this in, nevertheless for string format calls (where you are eagerly formatting the string, which is not always the case when logging), it's better to replace them with interpolated strings: $"v{Version} ({Updates.Count} updates by {Origin}) etag={ETag}"
Closed
jdom
pushed a commit
to jdom/orleans
that referenced
this pull request
Mar 22, 2017
sergeybykov
added a commit
that referenced
this pull request
Mar 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2845.