Directly propagate OnActivateAsync failures to callers #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failure can be ignored. |
sergeybykov
reviewed
Aug 18, 2017
| RerouteAllQueuedMessages(activation, null, "Failed InvokeActivate", exception); | ||
| // Reject all of the messages queued for this activation. | ||
| var activationFailedMsg = nameof(Grain.OnActivateAsync) + " failed"; | ||
| RejectAllQueuedMessages(activation, activationFailedMsg, exception); |
There was a problem hiding this comment.
Isn't there a race here that will allow new requests to get enqueue right after we reject all messages that are already in the queue? Are we preventing enqueuing of new requests before we start the rejection loop?
There was a problem hiding this comment.
The activation is already marked as invalid and this is running inside of a lock on the activation. Is there room for a race?
There was a problem hiding this comment.
If it's already marked as invalid, then I think we are fine.
|
Is this change available in 1.5.1 or 1.5.2 (and 1.5.1)? |
|
No, it's only in master. Will be in 2.0.0-beta. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3213
OnActivateAsyncwill be propagated directly back to the caller.IMessagingConfiguration.MaxResendCounttimes (default is 0) because the rejection is marked asTransient.OrleansMessageRejectionException) which typically contained the original exception'sMessagein itsMessageproperty.