Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate serializers for foreign types in Orleans.Streaming.EventHubs #4487

Merged
merged 2 commits into from
Apr 24, 2018
Merged

Don't generate serializers for foreign types in Orleans.Streaming.EventHubs #4487

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14a1f70
Don't generate serializers for foreign types in Orleans.Streaming.Eve…
ReubenBond Apr 18, 2018
e5a4af3
Add GenerateSerializer(typeof(EventHubSequenceToken))
ReubenBond Apr 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Azure/Orleans.Streaming.EventHubs/Properties/AssemblyInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
using System.Runtime.CompilerServices;
using Orleans.CodeGeneration;
using Orleans.ServiceBus.Providers;

[assembly: InternalsVisibleTo("ServiceBus.Tests")]

[assembly: KnownAssembly(typeof(EventHubSequenceTokenV2), TreatTypesAsSerializable = true)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is a serializer generated for EventHubSequenceTokenV2? It's not used in any grain interfaces. That's why it was previously marked with the GenerateSerializer attribute

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's marked as [Serializable]