Tx fixes #4616
Tx fixes #4616
Conversation
| @@ -102,6 +105,9 @@ public Task<ITransactionInfo> StartTransaction(bool readOnly, TimeSpan timeout) | |||
| if (logger.IsEnabled(LogLevel.Debug)) | |||
| logger.Debug($"{stopwatch.Elapsed.TotalMilliseconds:f2} timeout {transactionInfo.TransactionId} prepare responses"); | |||
|
|
|||
| foreach(var p in participants) | |||
| p.Key.Abort(transactionInfo.TransactionId).Ignore(); | |||
There was a problem hiding this comment.
Can the agent make this call? Isn't TM authoritative? What if tm has committed transaction the, but this times out?
There was a problem hiding this comment.
This is the logic for read-only transaction. For those, there is no TM, instead the TA "commits" the transaction after it receives all the prepare responses. These responses are sent by the participants after they unlock, and after they persist the clock.
| @@ -93,6 +93,9 @@ public Task<ITransactionInfo> StartTransaction(bool readOnly, TimeSpan timeout) | |||
| if (logger.IsEnabled(LogLevel.Debug)) | |||
| logger.Debug($"{stopwatch.Elapsed.TotalMilliseconds:f2} fail {transactionInfo.TransactionId} prepare response status={status}"); | |||
|
|
|||
| foreach (var p in participants) | |||
| p.Key.Abort(transactionInfo.TransactionId).Ignore(); | |||
There was a problem hiding this comment.
Shouldn't we wait for the aborts? If not, won't this allow future calls to fail because they may depend on the aborted operation.
There was a problem hiding this comment.
The point of these "aborts" is simply to tell the grains that they can unlock now. All locks time out pretty quickly (7 sec), but it is of course better to send the explicit abort messages, so that any transactions waiting for the lock can proceed immediately.
|
All of these bugs were found by the randomized consistency tests I am currently developing. These checks are not yet ready to check in - I haven't even gotten to the serializability checking yet - but they are already flushing out lots of bugs. I found one more yesterday afternoon, see the extra commit from this morning. I will create a separate PR for these tests when they are ready. |
|
@dotnet-bot test Ubuntu please |
|
@dotnet-bot test Ubuntu16.04 Release Build please |
Several bug fixes for bugs that caused hangs in my randomized tests
also, I made tracing in azure table transactional state storage more uniform.