Improve codegen's .NET Core 3 compatibility 2 #5883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enable build only with dotnet 3.0-preview8
|
|
|
@ReubenBond, as discussed in #5880 |
That would be great, thanks for doing this |
|
Done. Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5880
The fix allows the codegen for dotnet to use a runtime >= 3.0.0 as fallback if the 2.0 runtime cannot be found. This allow code generation in only dotnet 3.0 environments.
The changes are the same as for #5799 for the MSBuild codegenerator.
I also included the codegenerator in Bootstrap, so that building Orleans itself is now possible only with a dotnet 3.0 runtime.
It maybe a good idea to do that for the MSBuild codegen in Bootstrap, too. Should I include the change in this pull request?
Thanks,
Frank