-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bound connection attempt concurrency in ConnectionManager #5894
Merged
sergeybykov
merged 18 commits into
dotnet:master
from
ReubenBond:fix/networking/connection-attempt-concurrency
Sep 24, 2019
Merged
Bound connection attempt concurrency in ConnectionManager #5894
sergeybykov
merged 18 commits into
dotnet:master
from
ReubenBond:fix/networking/connection-attempt-concurrency
Sep 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
fix/networking/connection-attempt-concurrency
branch
from
August 22, 2019 21:13
7443de3
to
7e5ed61
Compare
ReubenBond
force-pushed
the
fix/networking/connection-attempt-concurrency
branch
15 times, most recently
from
September 9, 2019 19:41
af0b7ef
to
c0a3f15
Compare
ReubenBond
force-pushed
the
fix/networking/connection-attempt-concurrency
branch
2 times, most recently
from
September 13, 2019 17:33
82018d8
to
85dca00
Compare
ReubenBond
force-pushed
the
fix/networking/connection-attempt-concurrency
branch
from
September 13, 2019 17:48
85dca00
to
02be6c0
Compare
sergeybykov
approved these changes
Sep 16, 2019
message, | ||
CancellationToken.None, | ||
TaskCreationOptions.DenyChildAttach, | ||
TaskScheduler.Default); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we .Ignore()
this task?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add that or make sure the task cannot throw
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how
ConnectionManager
is implemented, especially in cases where there are multiple tasks waiting on a connection attempt.