Stateless worker local compatibility check #5917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you add a test case for stateless worker? In the code we have sometimes some specifics code path for this type. Look into the test class |
…hub.com/JohnMorman/orleans into StatelessWorkersCompatibilityCheckFirst
|
|
|
Added two tests based off of the HeterogeneousTests, let me know if that is the correct place to add or if you have any other suggestions |
|
Thanks, @JohnMorman! |
sergeybykov
pushed a commit
to sergeybykov/orleans
that referenced
this pull request
Oct 9, 2019
ReubenBond
pushed a commit
that referenced
this pull request
Oct 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the placement of stateless workers to not just blindly choose the local silo as the target. Instead we check if the local silo is compatible first, if it is then we choose it, otherwise we back off to the random logic which we previously used when the silo was shutting down.