Clear RequestContext when spawning connections #5974
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing reliability issues because new connections could occasionally be started due to a Ping message, which has a
"Ping"
RequestContext
header set. The connection would then capture thatRequestContext
and would import it into messages created by theSiloConnection
itself. These messages would then be treated as though they were Ping messages by the remote silo.Examples of such messages are:
IncomingMessageAgent.ReceiveMessage
is called synchronously from the connectionThis would result in timeouts (which can prevent a silo from starting), active silos being declared dead, obscure exceptions such as
Unrecoverable Rejection (info: System.InvalidOperationException: Expected result of type Orleans.GrainDirectory.AddressesAndTag but encountered a null value.)
, andNullReferenceExceptions
fromActivationDirectory.FindTarget