Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate message [de]serialization exceptions to callers #5998

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Propagate message [de]serialization exceptions to callers #5998

merged 2 commits into from
Oct 2, 2019

Conversation

ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Oct 1, 2019 •
edited

Currently when deserialization fails for a response message we do not propagate that deserialization exception to the caller. This PR adds behavior to propate such exceptions back to the original caller.

Fixes #4748

Fixes #5397

xref #5978

@ReubenBond ReubenBond added this to the 3.0.0 milestone Oct 1, 2019
This was referenced Oct 1, 2019
Closed
Closed
@ReubenBond ReubenBond force-pushed the fix/serialization-exception-messaging branch from c998b72 to c2614f9 Compare October 2, 2019 17:54
@ReubenBond ReubenBond force-pushed the fix/serialization-exception-messaging branch from c2614f9 to 2ec55e3 Compare October 2, 2019 18:05
@ReubenBond ReubenBond changed the title Propagate response deserialization exceptions to callers Propagate message [de]serialization exceptions to callers Oct 2, 2019
@ReubenBond ReubenBond force-pushed the fix/serialization-exception-messaging branch from 2ec55e3 to bde4bec Compare October 2, 2019 19:28
@ReubenBond
Copy link
Member Author

ReubenBond commented Oct 2, 2019 •
edited

Test failures caused by client object being garbage collected during the test 😅

[2019-10-02 19:11:22.053 GMT 83	Warning	100162	Orleans.InvokableObjectManager]	Object associated with Observer ID 8619307c-fb4a-4462-ab81-fbd3d5b107b8 has been garbage collected. Deleting object reference and unregistering it. Message = Request S127.0.0.1:45910:0*grn/415DDB74/0bc83f2f@4d535786->*cli/210fc689@7306d1658619307c-fb4a-4462-ab81-fbd3d5b107b8 #14052: 	
[2019-10-02 19:11:53.015 GMT 84	Warning	100157	Orleans.Runtime.CallbackData]	Response did not arrive on time in 00:00:30 for message: Request *cli/210fc689@2e449599->S127.0.0.1:45911:0*grn/415DDB74/0bc83f2f #14050: . Target History is: <S127.0.0.1:45911:0:*grn/415DDB74/0bc83f2f:>. About to break its promise.

@sergeybykov sergeybykov merged commit 9336dd1 into dotnet:master Oct 2, 2019
@ReubenBond ReubenBond deleted the fix/serialization-exception-messaging branch October 2, 2019 21:45
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergeybykov sergeybykov sergeybykov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
2 participants
@ReubenBond @sergeybykov