Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from WindowsAzure.Storage library to Microsoft.AzureCosmos.Table and Microsoft.Azure.Storage.* packages. #6013

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

sergeybykov
Copy link
Contributor

This is to complete the work started by @seniorquico in #5479.

Marked as WIP for now because there are four functional test failures to investigate, likely test issues.

@seniorquico
Copy link
Contributor

@sergeybykov Do you have the list of failing tests (when I click through to the Azure DevOps logs it shows 0 failures)? Additionally, are the instructions on configuring/running the functional test suite?

@sergeybykov sergeybykov changed the title [WIP] Move from WindowsAzure.Storage library to Microsoft.AzureCosmos.Table and Microsoft.Azure.Storage.* packages. Move from WindowsAzure.Storage library to Microsoft.AzureCosmos.Table and Microsoft.Azure.Storage.* packages. Oct 7, 2019
@sergeybykov
Copy link
Contributor Author

Test issues have been sorted out. This is ready for review/merge.

@sergeybykov
Copy link
Contributor Author

sergeybykov commented Oct 7, 2019

@seniorquico TestAll.cmd runs all functional tests. Some of them that have dependency on Azure Storage are skipped unless a OrleansTestSecrets.json with connection strings is found in the folder.

{
"DataConnectionString": "connection string",
"EventHubConnectionString": "connection string"
}

<MicrosoftAzureEventHubsVersion>2.2.1</MicrosoftAzureEventHubsVersion>
<MicrosoftAzureStorageBlobVersion>10.0.3</MicrosoftAzureStorageBlobVersion>
<MicrosoftAzureStorageQueueVersion>10.0.3</MicrosoftAzureStorageQueueVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we take the latest instead here? 11.1.0

@ReubenBond ReubenBond merged commit 85ba26a into dotnet:master Oct 8, 2019
@sergeybykov
Copy link
Contributor Author

Thank you,@seniorquico, for driving this PR!

@sergeybykov sergeybykov deleted the replace-table-storage branch October 9, 2019 16:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants