Update OneBoxDeployment to .NET Core 3 #6092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates OneBoxDeployment to .NET Core 3 while also cleaning code where appropriate.
|
This is not ready, but I thought that could open a PR nevertheless. |
|
Thanks, Veikko ☺ |
|
@ReubenBond, all right. I submit the rest of changes in separate PR(s). :) For instance, in problem case the problem detail result doesn't have the headers etc. set like I would and didnt't have time to find out. Consequently also the test that checks the API gives the error results out as expected fails (i.e. the header set certain way). Maybe not too fatal, maybe better to have something in and not waiting the next three weeks I get things resolved. :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates OneBoxDeployment to .NET Core 3 while also cleaning code where appropriate.