Made ShouldPurge protected and virtual in eviction strategy. #6560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jason-bragg
reviewed
Jun 1, 2020
| /// <param name="newestCachedMessage"></param> | ||
| /// <param name="nowUtc"></param> | ||
| /// <returns></returns> | ||
| bool ShouldPurge(ref CachedMessage cachedMessage, ref CachedMessage newestCachedMessage, DateTime nowUtc); |
There was a problem hiding this comment.
Why add this to the abstraction. Is called by other? Shouldn't currently be, as it was private.
| @@ -84,6 +84,16 @@ public void PerformPurge(DateTime nowUtc) | |||
| this.periodicMonitoring?.TryAction(nowUtc); | |||
| } | |||
|
|
|||
| /// <inheritdoc /> | |||
| public virtual bool ShouldPurge(ref CachedMessage cachedMessage, ref CachedMessage newestCachedMessage, DateTime nowUtc) | |||
There was a problem hiding this comment.
Unless it needs to be public, suggest making it a protected virtual. Specializations can override, but still an implementation detail of this strategy.
There was a problem hiding this comment.
Okay, will make it protected virtual, somehow that skipped my mind that a "protected virtual" would also work.
ghost
changed the title
jason-bragg
approved these changes
Jun 1, 2020
|
Thank you @adyada ! |
|
Thanks @jason-bragg for quick review and merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing some cases where some items from cache are purged before they get delivered to a grain, as they satisfy the time purge criteria. It could also be because of some customizations we have done to Orleans streaming.
So, just making ShouldPurge as public method so that we can customize it, like only purge cache messages whose sequence token is less than min read sequence token in last 15 mins or something.