Observe discarded ping task results #6577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
reviewed
Jun 5, 2020
| @@ -31,7 +31,7 @@ public static void Ignore(this Task task) | |||
| task.ContinueWith( | |||
| IgnoreTaskContinuation, | |||
| CancellationToken.None, | |||
| TaskContinuationOptions.NotOnRanToCompletion | TaskContinuationOptions.ExecuteSynchronously, | |||
| TaskContinuationOptions.OnlyOnFaulted | TaskContinuationOptions.ExecuteSynchronously, | |||
There was a problem hiding this comment.
To avoid running the continuation if the task is canceled, just more optimal.
There was a problem hiding this comment.
I ran some tests and the behavior seems fine
|
Thank you, Pent! |
sergeybykov
pushed a commit
that referenced
this pull request
Jun 30, 2020
(cherry picked from commit 962b3f8)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always observe ping task results, even if they are discarded (canceled).