AAD authentication for Azure Event Hub #6667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelij
commented
Jul 29, 2020
| eventData.SetPartitionKey(this.StreamId.Guid.ToString()); | ||
| var wrapper = new WrappedEventData(eventData.Body, eventData.Properties, eventData.SystemProperties, | ||
| partitionKey: StreamId.Guid.ToString(), | ||
| offset: DateTime.UtcNow.Ticks, |
There was a problem hiding this comment.
I'm not sure about this change. Previously offset was set to StreamId.Guid.ToString() + now.ToString, but this is impossible now that it's long.
pentp
reviewed
Aug 4, 2020
|
There are some conflicts now that the other PR is merged. Could you please rebase on master and force-push? |
|
@aelij thank your for your PR! I am ok to merge it, if you could resolve the conflict. Otherwise I can resolve them myself, since they are most likely due to my I don't think we will backport this PR to 3.3.0 to limit the risk though. |
|
@benjaminpetit I'd appreciate it if you could resolve them |
Use Azure.Identity only in tests
|
/azp run Azure DevOps - Functional |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note there are a few minor breaking changes:
longinstead ofstringEventDatais immutable, so I've removedEventDataProxyMethods